Re: [openib-general] Re: [PATCH 21/22] ehca main file

[Heiko J Schick]

Hello Anton,

thanks for your help!

>>+#include "hcp_sense.h"		/* TODO: later via hipz_* header file */
>>+#include "hcp_if.h"		/* TODO: later via hipz_* header file */
>
>
> I count 88 TODOs in the driver, it would be nice to get rid of some of
> them like the two above, so we can concentrate on the important TODOs :)

We will remove the TODOs soon as possible.

>>+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,12)
>>+#define EHCA_RESOURCE_ATTR_H(name)                                         \
>>+static ssize_t  ehca_show_##name(struct device *dev,                       \
>>+				 struct device_attribute *attr,            \
>>+				 char *buf)
>>+#else
>>+#define EHCA_RESOURCE_ATTR_H(name)                                         \
>>+static ssize_t  ehca_show_##name(struct device *dev,                       \
>>+				 char *buf)
>>+#endif
>
>
> No need for kernel version ifdefs.

The point is that our module have to run on Linux 2.6.5-7.244 (SuSE SLES 9 SP3), too.
This was the reason why we've included the ifdefs. We can change the ifdefs to
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2.6.5) to mark that this code is used for
Linux 2.6.5 compatibility.

Regards,
	Heiko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/