Re: suspend2 review [was Re: Which is simpler? (Was Re: [Suspend2-devel] Re: [ 00/10] [Suspend2] Modules support.)]

[Olivier Galibert]

On Mon, Feb 20, 2006 at 01:49:37PM +0100, Pavel Machek wrote:
> > > Yep, if you do it all in userspace, this vanishes. 340 lines down.
> > 
> > And you gain? Let's try not to be too biased :).
> 
> I gain 340 less lines to review. For me to review, for akpm to review,
> and for Linus to review. That's important.

Pavel, if you mean that the userspace code will not be reviewed to
standards the kernel code is, kill uswsusp _NOW_ before it does too
much damage.  Unreliable suspend eats filesystems for breakfast.  The
other userspace components of the kernels services are either optional
(udev) or not that important (alsa).

  OG.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/