Re: suspend2 review [was Re: Which is simpler? (Was Re: [Suspend2-devel] Re: [ 00/10] [Suspend2] Modules support.)]

[Pavel Machek]

On Po 20-02-06 19:31:36, Olivier Galibert wrote:
> On Mon, Feb 20, 2006 at 06:10:00PM +0100, Pavel Machek wrote:
> > On Po 20-02-06 18:05:37, Olivier Galibert wrote:
> > > On Mon, Feb 20, 2006 at 01:49:37PM +0100, Pavel Machek wrote:
> > suspend2 received no such review, and still people claim it is
> > reliable.
> 
> Plain numbers.  Just count the "suspend2 works for me which swsusp
> doesn't".  I doubt it's purely luck, even if simply moving code around
> can change behaviours.

Well, people with broken swsusp tend to try suspend2... that's why you
see so many reports. if you merged suspend2 and dropped swsusp, it
would be the other way around. 

> > "I wish they'd kill suspend2 project, it already did enough
> > damage." (Half joking here, but suspend2 split user/development
> > community, and that's not good).
> 
> Yes, that's annoying.  But be careful, you seem to be automatically
> rejecting everything Nigel at that point, or at least that's what it
> looks like.

I'm not rejecting _everything_ Nigel does, but I have seen very little
acceptable kernel patches from him.

> You do what you want, obivously, but I suspect your reviews of the
> suspend2 code would be way more interesting if you accepted it's not
> uswsusp.  Right now, they look more religious/political than really
> technical.

Feel free to review suspend2 yourself. You are likely to find many
small issues, and Nigel is likely to fix them; but that's useless: as
long as big issues are not fixed, code is not suitable for mainline
merge.

(And it is going to be easier to do it in userspace using existing -mm
infrastructure then to clean suspend2 patches).

Feel free to review suspend.sf.net code if you want to help; testing
would be useful at this point, too.
								Pavel
-- 
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/