Re: [PATCH 3/6] PCI legacy I/O port free driver (take2) - Add device_flags into pci_device_id

From: Andi Kleen
Date: Tue Feb 21 2006 - 15:58:24 EST


On Tuesday 21 February 2006 21:56, Greg KH wrote:

> I don't think you can add fields here, after the driver_data field. It
> might mess up userspace tools a lot, as you are changing a userspace
> api.

User space should look at the ASCII files (modules.*), not the binary
As long as the code to generate these files still works it should be ok.

> Do you _really_ need to pass this information back from userspace to the
> driver in this manner?

Well driver_data wouldn't be needed then either. Obviously it's for more
than just userspace.

-Andi


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/