Re: [PATCH] tmpfs: fix mount mpol nodelist parsing

[Andrew Morton]

Hugh Dickins <hugh@xxxxxxxxxxx> wrote:
>
> Move the mpol= parsing to shmem_parse_mpol under CONFIG_NUMA, reject
>  all its options as invalid if not NUMA.

That's a bit irritating, really.  It means that userspace needs to be
different for NUMA kernels (or more different, which is still bad).  Boot
into a non-NUMA kernel and whoops, no tmpfs and quite possibly no boot.

But last time I whined about this Albert had a list of fairly
reasonable-sounding reasons why filesystems shouldn't silently accept
not-understood options.

But in this case, we _do_ understand them.  We're just not going to do
anything about them.

I just wonder if we're being as friendly as we possibly can be to admins
and distro-makers.

[ Vaguely suprised that tmpfs isn't using match_token()... ]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/