Re: sys_mmap2 on different architectures

[H. Peter Anvin]

David S. Miller wrote:
> From: Benjamin LaHaise <bcrl@xxxxxxxxx>
> Date: Wed, 22 Feb 2006 19:14:11 -0500
>
>
> > The sys_mmap2() ABI is that the page shift is always fixed to whatever 
> > page size is reasonable for the architecture, typically 2^12.  The syscall 
> > should never be exposed as mmap2(), only as the large file size version 
> > of mmap() (aka mmap64()).  The other consideration is that it should not 
> > be implemented in 64 bit ABIs, as those machines should be using a 64 bit 
> > native mmap().  Does that clear things up a bit?  Cheers,
>
>
> Aha, that part I didn't catch.  Thanks for the clarification
> Ben.
>
> I wonder why we did things that way with a fixed shift...

Except the above doesn't seem to match reality on anything other than 
SPARC, and the architectures where the shift is 12 anyway because that's 
the only pagesize supported.

On the other hand, sys32_mmap2 on SPARC64 matches the SPARC32 sys_mmap2 
in that the shift is hard-coded to 12:

        .globl          sys32_mmap2
sys32_mmap2:
        sethi           %hi(sys_mmap), %g1
        jmpl            %g1 + %lo(sys_mmap), %g0
         sllx           %o5, 12, %o5


At this point, I'm more than willing to treat SPARC as a special case, 
but I really want to know what the rules actually _ARE_ as opposed to 
what they are supposed to be (which they clearly are not.)

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/