Re: slab: Remove SLAB_NO_REAP option

[Christoph Lameter]

On Thu, 23 Feb 2006, Andrew Morton wrote:

> I'm very much hoping that it is not needed.  Would prefer to just toss the
> whole thing away.

Right.

> What's it supposed to do anyway?  Keep wholly-unused pages hanging about in
> each slab cache?  If so, it may well be a net loss - it'd be better to push
> those pages back into the page allocator so they can get reused for
> something else while they're possibly still in-cache.  Similarly, it's
> better to fall back to the page allocator for a new slab page because
> that's more likely to give us a cache-hot one.

There needs to be some convincing rationale for SLAB_NO_REAP plus the 
documentation should be updated to explain correctly what it does if we 
decide to keep SLAB_NO_REAP.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/