Re: Which is simpler? (Was Re: [Suspend2-devel] Re: [ 00/10] [Suspend2] Modules support.)

[Pavel Machek]

On Ät 23-02-06 23:37:30, Rafael J. Wysocki wrote:
> Hi,
> 
> On Thursday 23 February 2006 13:17, Pavel Machek wrote:
> > > > Ok, I have no problems with visions.
> > > > 
> > > > > I think we should try to get the pagecache stuff right first anyway.
> > > > 
> > > > Are you sure it is worth doing? I mean... it only helps on small
> > > > machines, no?
> > > > 
> > > > OTOH having it for benchmarks will be nice, and perhaps we could use
> > > > that kind it to speed up boot and similar things... 
> > > 
> > > Currently some people can't suspend with the mainline code because it cannot
> > > free as much memory as needed on their boxes.  I think we should care for them
> > > too.
> > 
> > But saving pagecache will not help them *at all*!
> > 
> > [Because pagecache is freeable, anyway, so it will be freed. Now... I
> > have seen some problems where free_some_memory did not free enough,
> > and schedule()/retry helped a bit... that probably should be fixed.]
> 
> It seems I need to understand correctly what the difference between what
> we do and what Nigel does is.  I thought the Nigel's approach was to save
> some cache pages to disk first and use the memory occupied by them to
> store the image data.  If so, is the page cache involved in that or something
> else?

I believe Nigel only saves pages that could have been freed anyway
during phase1. Nigel, correct me here... suspend2 should work on same
class of machines swsusp can, but will be able to save caches on
machines where swsusp can not save any.
								Pavel

-- 
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/