Re: Slab: Node rotor for freeing alien caches and remote per cpupages.

[Andrew Morton]

Christoph Lameter <clameter@xxxxxxxxxxxx> wrote:
>
> +void drain_node_pages(int nodeid)
>   {
>  -	struct zone *zone;
>  -	int i;
>  +	int i, z;
>   	unsigned long flags;
>   
>   	local_irq_save(flags);
>  -	for_each_zone(zone) {
>  +	for (z = 0; z < MAX_NR_ZONES; z++) {
>  +		struct zone *zone = NODE_DATA(nodeid)->node_zones + z;
>   		struct per_cpu_pageset *pset;
>   
>  -		/* Do not drain local pagesets */
>  -		if (zone->zone_pgdat->node_id == numa_node_id())
>  -			continue;
>  -
>   		pset = zone_pcp(zone, smp_processor_id());
>   		for (i = 0; i < ARRAY_SIZE(pset->pcp); i++) {

Should it be testing populated_zone() in there?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/