Re: [PATCH] x86_64 stack trace cleanup

[Randy.Dunlap]

On Fri, 24 Feb 2006, Andrew Morton wrote:

> Andi Kleen <ak@xxxxxxx> wrote:
> >
> > On Friday 24 February 2006 13:50, Andrew Morton wrote:
> > > Andi Kleen <ak@xxxxxxx> wrote:
> > > >
> > > > I can offer you a deal though: if you fix VGA scrollback to have
> > > >  at least 1000 lines by default we can change the oops formatting too.
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc4/2.6.16-rc4-mm2/broken-out/vgacon-add-support-for-soft-scrollback.patch
> >
> > Once that is in and works we can consider changing the oopses.
> >
>
> I don't think we should change the oops format.
>
> Apart from no longer printing a hex-base+decimal-offset, which is braindead.

strongly agree with the hex/decimal braindead part.

> > > Problem is, scrollback doesn't work after panic().  I don't know why..
> >
> > Someone claimed it was related to the panic keyboard blinking.
> >
>
> Strange.  It looks pretty harmless.

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/