Re: s_vfs_rename_sem and cifs (was Re: Possible deadlock in vfs layer, namei.c)

From: Al Viro
Date: Thu Mar 02 2006 - 06:51:58 EST


On Thu, Mar 02, 2006 at 03:47:50AM -0800, Alexey Dobriyan wrote:
> On Wed, Mar 01, 2006 at 06:46:42PM -0800, Joshua Hudson wrote:
> > from namei.c (function: lock_rename), rename takes:
> > 1. s_vfs_rename_sem,
>
> Speaking of s_vfs_rename_sem, does cifs usage of it despite explicit
> warning at fs.h
> was found to be legal?

Legal as in "works until anything changes in VFS-internal locking".
Not legal as in "not promised to keep working".
Dumb in all respects.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/