Re: [PATCH] for_each_possible_cpu [1/19] defines for_each_possible_cpu

[Nick Piggin]

KAMEZAWA Hiroyuki wrote:
> On Thu, 16 Mar 2006 14:43:38 +1100
> Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
>
> > The only places where things might care is arch bootup code, but
> > the cpu interface is such that the arch code is expected to _hide_
> > any weird details from these generic interfaces.
>
> Please see i386 patch. it contains BUG fix.
> cpu_msrs[i].coutners are allocated by for_each_online_cpu().
> and free it by for_each_possible_cpus() without no pointer check.

Well that's another problem then, such a fix should not be sent in
this patchset, but as a separate patch.

> I think this kind of confusion will be seen again in future.

I'm sure that renaming for_each_cpu would not prevent that either.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/