Re: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c

[Ralf Baechle]

On Thu, Mar 16, 2006 at 02:42:11PM +0800, Eugene Teo wrote:

> Pointer ax is dereferenced before NULL check.
> 
> Coverity bug #817

Coverity non-bug #817.  The line discipline's ioctl method can only be
called as long as sp_get(tty) is valid.  Same for mkiss.

Unless I'm wrong on the "locking rules" of the tty code that is and maybe
that unobviousness is the real reason why the patch should be applied.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/