Re: [PATCH] for_each_possible_cpu [1/19] defines for_each_possible_cpu
From: Nick Piggin
Date: Thu Mar 16 2006 - 10:11:27 EST
Andrew Morton wrote:
Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
for_each_cpu has always meant for
each possible CPU.
That was the most long-winded ack I've ever seen ;)
Is not! :). This is the very reason why I think it is pointless churn.
There are plenty of functions (even static, confined to a single file,
or ones much more complex than this) which could unquestionably have
their names changed for the better.
This change doesn't even add anything except a redundant element so
it is even questionable that it makes the name better at all.
But I know you've got your heart set on them now so I won't continue
with the impossible task of talking you out of them ;) Just don't
expect that people will suddenly start getting hotplug-cpu races
right, overnight.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/