Re: [PATCH 10 of 20] ipath - support for userspace apps using coredriver

From: Bryan O'Sullivan
Date: Thu Mar 16 2006 - 12:41:49 EST


On Thu, 2006-03-16 at 17:27 +0000, Hugh Dickins wrote:

> There's no need to do a get_page after the allocation and a put_page
> before the free (though you could, it's just extra unnecessary work):
> the allocation comes with a reference count of 1, the free frees up
> that last remaining reference count of 1 (as Andrew explained more
> lucidly elsewhere in his mail).

All right. I followed your advice and you are indeed correct; the added
get_page and put_page were not necessary; __GFP_COMP alone did the
trick.

Thanks,

<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/