Re: RFC: radix tree safety

From: Nick Piggin
Date: Thu Mar 16 2006 - 19:40:25 EST


Jonathan Corbet wrote:
Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:


How about making the code self-documenting and more useful at the same
time: put RADIX_TREE_TAGS in radix-tree.h, and call it RADIX_TREE_MAX_TAGS


I like that idea - how's the following? I also took the liberty of
making the tag arguments be unsigned, since that is clearly the way they
are intended to be used.


Looks really good. Andrew will you pick it up?

jon


Documentation changes to help radix tree users avoid overrunning the
tags array. RADIX_TREE_TAGS moves to linux/radix-tree.h and is now
known as RADIX_TREE_MAX_TAGS (Nick Piggin's idea). Tag parameters are
changed to unsigned, and some comments are updated.

Signed-off-by: Jonathan Corbet <corbet@xxxxxxx>

...

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/