Re: -mm: PM=y, VT=n doesn't compile

[Andrew Morton]

Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
>  swsusp-pm-refuse-to-suspend-devices-if-wrong-console-is-active.patch
>  causes the following compile error with CONFIG_PM=y, CONFIG_VT=n:
> 
>  <--  snip  -->
> 
>  ...
>    LD      .tmp_vmlinux1
>  drivers/built-in.o: In function `device_suspend': undefined reference to `fg_console'
>  drivers/built-in.o: In function `device_suspend': undefined reference to `vc_cons'
>  make: *** [.tmp_vmlinux1] Error 1

Right, thanks.  I'll drop that patch.

Guys, please don't go poking around in the vt subsystems's internal data
structures from within power management code.

Write a nice little helper function, put that in vt.c, give it a static
inline `return 0' stub in the header file, then call that.

That's Kernel Programming 101, no?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/