Re: [3/3 PATCH] Kprobes: User space probes support- singlestepping out-of-line

[Arjan van de Ven]

> And we'll need to actually *be* in-atomic.  That means we need an
> open-coded inc_preempt_count() and dec_preempt_count() in there and I don't
> see them.
> 

..

> Why is VM_LOCKED being set? (It needs a comment).
> 
> Where does it get unset?


if this is an attempt to make the copy_in_atomic to be atomic, then it
is a bug; the user can unset this bit after all via mprotect, even from
another thread, and concurrently. UnGood(tm).


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/