Re: [PATCH] scm: fold __scm_send() into scm_send()

From: Chris Wright
Date: Mon Mar 20 2006 - 18:46:37 EST


* David S. Miller (davem@xxxxxxxxxxxxx) wrote:
> From: Chris Wright <chrisw@xxxxxxxxxxxx>
> Date: Mon, 20 Mar 2006 13:36:36 -0800
>
> > The point of Catherine's original patch was to make sure there's always
> > a security identifier associated with AF_UNIX messages. So receiver
> > can always check it (same as having credentials even w/out sender
> > control message passing them). Now we will have garbage for sid.
>
> I'm seriously considering backing out Catherine's AF_UNIX patch from
> the net-2.6.17 tree before submitting it to Linus later today so that
> none of this crap goes in right now.
>
> It appears that this needs a lot more sorting out, so for now that's
> probably the right thing to do.

I won't object. I checked your tree, it looks OK to me. The actual
broken patch appears in -mm, and the security_sid_to_context snafu
is primarily cosmetic at this point (the exports, etc fixed the real
compilation issues AFAICT). But, again, if you want to drop that's fine
w/ me. I'm sure Catherine can cleanup and resend as needed.

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/