Re: [PATCH] Check for online cpus before bringing them up

[Shaohua Li]

On Mon, 2006-03-20 at 17:25 -0800, Ashok Raj wrote:
> On Tue, Mar 21, 2006 at 09:08:05AM +0800, Shaohua Li wrote:
> > > +
> > > +#ifdef CONFIG_HOTPLUG_CPU
> > > +	/*
> > > +	 * We do warm boot only on cpus that had booted earlier
> > > +	 * Otherwise cold boot is all handled from smp_boot_cpus().
> > > +	 * cpu_callin_map is set during AP kickstart process. Its reset
> > > +	 * when a cpu is taken offline from cpu_exit_clear().
> > > +	 */
> > > +	if (!cpu_isset(cpu, cpu_callin_map))
> > > +		ret = __smp_prepare_cpu(cpu);
> > Does this work for boot time? cpu_callin_map isn't set at boot time for
> > APs.
> > 
> Yes,
> 
> I tested on a 2 way system and it booted fine. This is set durng the kickstart process
> when smp_callin() is called after AP receives boot ipi.
Ok, thanks! It should work for suspend/resume.

Thanks,
Shaohua


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/