Re: [PATCH 16/23] Kobject: provide better warning messages when peopledo stupid things

[Artem B. Bityutskiy]

Greg Kroah-Hartman wrote:
> +
> +		/* be noisy on error issues */
> +		if (error == -EEXIST)
> +			printk("kobject_add failed for %s with -EEXIST, "
> +			       "don't try to register things with the "
> +			       "same name in the same directory.\n",
> +			       kobject_name(kobj));

This looks like an attempt to put documentation into kernel code. Isn't 
 it better to add good documentation to the header file just above the 
prototype?

When I started using sysfs, I noticed a lack of good comments above 
prototypes of exported functions.

--
Best regards, Artem B. Bityutskiy
Oktet Labs (St. Petersburg), Software Engineer.
+7 812 4286709 (office) +7 911 2449030 (mobile)
E-mail: dedekind@xxxxxxxxxxxx, Web: www.oktetlabs.ru
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/