Re: [PATCH 35/46] kbuild: change kbuild to not rely on incorrect GNU make behavior

[Jan-Benedict Glaw]

On Tue, 2006-03-21 17:20:57 +0100, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index c201ef0..d3038b7 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile
> @@ -82,7 +82,7 @@ clean-dirs += $(objtree)/debian/
>  
>  # tarball targets
>  # ---------------------------------------------------------------------------
> -.PHONY: tar%pkg
> +PHONY += tar%pkg
>  tar%pkg:
>  	$(MAKE) KBUILD_SRC=
>  	$(CONFIG_SHELL) $(srctree)/scripts/package/buildtar $@

This part is wrong. $(PHONY) isn't subject to pattern matching, so all
targets that match 'tar%pkg' must be listed here. Fortunately, that's
only three:

PHONY += tar-pkg targz-pkg tarbz2-pkg

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@xxxxxxxxxx    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fÃr einen Freien Staat voll Freier BÃrger"  | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature