Re: [RFC] [PATCH 1/7] Add process virtualisation umbrella structure(vx_info)

From: Sam Vilain
Date: Tue Mar 21 2006 - 16:49:56 EST


Dave Hansen wrote:

>On Tue, 2006-03-21 at 18:13 +1200, Sam Vilain wrote:
>
>
>>+static inline void release_vx_info(struct vx_info *vxi,
>>+ struct task_struct *task)
>>+{
>>+ might_sleep();
>>+
>>+ if (atomic_dec_and_test(&vxi->vx_tasks))
>>+ unhash_vx_info(vxi);
>>+}
>>
>>
>
>Are these better handled by krefs and their destructors?
>
>

It does seem a little clumsy, doesn't it. I've found
Documentation/kref.txt and will rewrite those functions to use this API.

Sam.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/