Re: [PATCH 04/23] driver core: platform_get_irq*(): return -ENXIO on error

[Olivier Galibert]

On Tue, Mar 21, 2006 at 08:31:25PM +0000, Russell King wrote:
> On Tue, Mar 21, 2006 at 01:50:49PM +0100, Olivier Galibert wrote:
> > On Tue, Mar 21, 2006 at 08:07:09AM +0000, Russell King wrote:
> > > On Tue, Mar 21, 2006 at 01:13:36AM +0100, Olivier Galibert wrote:
> > > > On Mon, Mar 20, 2006 at 02:00:38PM -0800, Greg Kroah-Hartman wrote:
> > > > > platform_get_irq*() cannot return 0 on error as 0 is a valid IRQ on some
> > > > > platforms, return -ENXIO instead.
> > > > 
> > > > 0 is NO_IRQ, and can not be a valid IRQ number, ever.  A
> > > > platform_get_irq*() returning 0 as a valid irq is buggy.
> > > > 
> > > > Check http://lkml.org/lkml/2005/11/21/211
> > > 
> > > No.  That's Linus' _opinion_, which is not applicable to systems without
> > > the obviously broken PCI or ISA busses.  On such systems, IRQ0 has no
> > > special meaning what so ever.
> > 
> > Do the drivers know?
> 
> If you look at the following patch in the series, the users of this function
> have been updated.  So the answer is "yes".

They've just been updated not to barf with -ENOENT, nothing more.
That's nowhere near an audit of use of the return value.

But whatever, I'm not the one who will have to debug it.

  OG.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/