Re: [PATCH 2/2] Add full sysfs support to the IPMI driver

From: Arjan van de Ven
Date: Wed Mar 22 2006 - 03:58:26 EST


On Tue, 2006-03-21 at 16:13 -0600, Corey Minyard wrote:


> +static void ipmi_bmc_release(struct device *dev)
> +{
> + printk(KERN_DEBUG "ipmi_bmc release\n");
> +}


eehhhh NO.
Please read the many comments and documentations about why a release
function is NOT allowed to be empty. In fact the kernel warned you about
that, didn't it?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/