Re: [patch 3/24] s390: channel path measurements.

[Cornelia Huck]

On Wed, 22 Mar 2006 13:26:55 -0800
Andrew Morton <akpm@xxxxxxxx> wrote:

> hm, it's somewhat unusual for MAX_FOO to be inclusive.  Usually it means
> "greatest possible+1".

__MAX_SUBCHANNEL and friends in drivers/s390/cio/css.h all use the same
semantics :)

> > +static inline int
> > +__chsc_do_secm(struct channel_subsystem *css, int enable, void *page)
> 
> This has two callsites.  inlining it probably deoptimises things.

OK.

> 
> > +	secm_area->request = (struct chsc_header) {
> > +		.length = 0x0050,
> > +		.code   = 0x0016,
> > +	};
> 
> gcc tends to generate poor code for this construct.

Switching this to direct initialization seems to save a mvc. I'll
convert all instances in chsc.c for consistency.

Cornelia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/