Re: 2.6.16-mm1

[Andrew Morton]

Dave Jones <davej@xxxxxxxxxx> wrote:
>
> On Thu, Mar 23, 2006 at 01:40:46AM -0800, Andrew Morton wrote:
> 
>  > - Be aware that someone-who-doesn't-know-about-allmodconfig has screwed up
>  >   AGP on x86_64: if your link fails with various missing AGP symbols you'll
>  >   need to set the various CONFIG_AGP* symbols to `y' rather than `m'.  Then
>  >   work out which other Kconfig rule keeps on flipping them back to `m' again,
>  >   then fix that too.
> 
> I haven't merged anything into agpgart-git for a week or two, so it's
> more than likely..
> 
>  > +x86_64-mm-via-agp.patch
>  > +x86_64-mm-sis-agp.patch
>  > 
>  >  x86_64 tree updates
> 
> 
> whatever these are.
> 

THose patches come from someone who is pretending to be davej@xxxxxxxxxx ;)

We suspect the culprit is git-intelfb, which does

 config FB_INTEL
 	tristate "Intel 830M/845G/852GM/855GM/865G support (EXPERIMENTAL)"
-	depends on FB && EXPERIMENTAL && PCI && X86_32
+	depends on FB && EXPERIMENTAL && PCI && X86
 	select AGP
 	select AGP_INTEL
 	select FB_MODE_HELPERS

It's rather nasty that this can break the build.

It also seems plain wrong to me that a "select AGP" can force CONFIG_AGP=y
into CONFIG_AGP=m.  There's no sense in that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/