Re: 2.6.16-mm1

[Rafael J. Wysocki]

On Friday 24 March 2006 02:12, john stultz wrote:
> On Fri, 2006-03-24 at 02:04 +0100, Rafael J. Wysocki wrote:
> > On Friday 24 March 2006 01:49, john stultz wrote:
> > > On Thu, 2006-03-23 at 16:04 -0800, Andrew Morton wrote:
> > > > "R. J. Wysocki" <Rafal.Wysocki@xxxxxxxxxx> wrote:
> > > > >
> > > > > On Thursday 23 March 2006 10:40, Andrew Morton wrote:
> > > > > > 
> > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16/2.6.16-mm1/
> > > > > 
> > > > > On a uniprocessor AMD64 w/ CONFIG_SMP unset (2.6.16-rc6-mm2 works on this box
> > > > > just fine, .config attached):
> > > > 
> > > > hm, uniproc x86_64 seems to cause problems sometimes.  I should test it more.
> > > > 
> > > > > }-- snip --{
> > > > > PID hash table entries: 4096 (order: 12, 32768 bytes)
> > > > > time.c: Using 3.579545 MHz WALL PM GTOD PIT/TSC timer.
> > > > > time.c: Detected 1795.400 MHz processor.
> > > > > disabling early console
> > > > > Console: colour dummy device 80x25
> > > > > time.c: Lost 103 timer tick(s)! rip 10:start_kernel+0x121/0x220
> > > > > last cli 0x0
> > > > > last cli caller 0x0
> > > > > time.c: Lost 3 timer tick(s)! rip 10:__do_softirq+0x44/0xc0
> > > > > last cli 0x0
> > > > > last cli caller 0x0
> > > > > time.c: Lost 3 timer tick(s)! rip 10:__do_softirq+0x44/0xc0
> > > 
> > > It seems report_lost_ticks has been set to one w/ 2.6.16-mm1, thus these
> > > debug messages will be shown.
> > > 
> > > Rafael: To properly compare, could you boot 2.6.16-rc6-mm2 w/ the
> > > "report_lost_ticks" boot option and see if the same sort of messages do
> > > not appear?
> > 
> > It looks similar but not the same:
> 
> Yea, I think thats due to some new code from Andi.
> 
> The lost tick issue should be looked into (might be hardware SMIs), but
> it seems this is not caused by my patches.

You are right.  All of this is caused by report_lost_ticks set to 1.
The appended patch helps.

Thanks,
Rafael

---
 arch/x86_64/kernel/time.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.16-mm1/arch/x86_64/kernel/time.c
===================================================================
--- linux-2.6.16-mm1.orig/arch/x86_64/kernel/time.c
+++ linux-2.6.16-mm1/arch/x86_64/kernel/time.c
@@ -63,7 +63,7 @@ static unsigned long hpet_period;			/* f
 unsigned long hpet_tick;				/* HPET clocks / interrupt */
 int hpet_use_timer;				/* Use counter of hpet for time keeping, otherwise PIT */
 unsigned long vxtime_hz = PIT_TICK_RATE;
-int report_lost_ticks = 1;			/* command line option */
+int report_lost_ticks;				/* command line option */
 unsigned long long monotonic_base;
 
 struct vxtime_data __vxtime __section_vxtime;	/* for vsyscalls */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/