Re: [uml-devel] Re: [PATCH 12/16] UML - Memory hotplug

[Jeff Dike]

On Sat, Mar 25, 2006 at 12:58:57AM +0100, Blaisorblade wrote:
> > +int os_drop_memory(void *addr, int length)
> > +{
> > +     int err;
> > +
> > +     err = madvise(addr, length, MADV_REMOVE);
> > +     if(err < 0)
> > +             err = -errno;
> 
> Jeff, did you mean the "return _0_" rather than "return err" below? It's 
> incoherent with the existance of the "err" local.
> 
> > +     return 0;
> > +}

That's just a brain fart - will fix.

				Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/