Re: [RFC][PATCH 0/2] KABI example conversion and cleanup

[Kyle Moffett]

On Sun, 26 Mar 2006 06:52:05 -0500 Kyle Moffett <mrmacman_g4@xxxxxxx> wrote:
> 2)  Since most of the headers are currently quite broken with respect to
>     GLIBC and userspace, I won't spend much extra time preserving
>     compatibility with GLIBC, userspace, or non-GCC compilers.

That didn't come out right, but what I meant to say was this:  Since the 
headers in include/linux are quite broken with respect to GLIBC and 
userspace, I won't let so-called "compatibility" code like this get in 
the way:
  #ifndef __GNUC__
  #define DO_SOMETHING(foo) ICKY_MACRO
  #else
  static __inline__ void DO_SOMETHING(int foo)
  {
  	sensible_inline_function();
  }
  #endif

You can see where I take that approach in the patches I sent.

One other thing I would like to point out:  The fd_set code wants to use
__set_bit and __clear_bit from <linux/bitops.h>, but those really should
not be accessible to userspace directly.  I would like to propose moving
that functionality into <__klib/*.h> from which it would be accessible
to both <linux/*.h> and <kabi/*.h>.  I think this would also help with 
the UML header issues by providing those kernel-internal APIs to the 
kernel when run from userspace. (Please correct me if I'm wrong).

I appreciate your comments and corrections, thanks!

Cheers,
Kyle Moffett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/