Re: Papouch USB thermometer support

[Kalin KOZHUHAROV]

Folkert van Heusden wrote:
> The following patch against 2.6.15 adds support for the www.Papouch.com
> USB thermometer by adding the appropriate vendor and product id.

OK, this should probably work, but adding a new device support might require
a bit more effort...

And since I started looking into the code, I think it may see some
cleanup, so I'll be submitting shortly a series of two patches, yours included
as a second one. I'll CC you and please add the correct Signed-off-by line if
you agree and repost.

The page for this device is here:
http://www.papouch.com/shop/scripts/_detail.asp?katcislo=0188

Specs (in Polish) here:
http://www.papouch.com/shop/scripts/pdf/tmu.pdf

> 
> 
Be careful with this line:
> Signed off: Folkert van Heusden <folkert@xxxxxxxxxxxxxx

Should be:
Signed-off-by: Folkert van Heusden <folkert@xxxxxxxxxxxxxx>

> diff -uNrbBd old/ftdi_sio.c new/ftdi_sio.c
> --- old/ftdi_sio.c      2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.c      2006-03-24 20:33:20.000000000 +0100
> @@ -307,6 +307,7 @@
> 
> 
>  static struct usb_device_id id_table_combined [] = {
> +       { USB_DEVICE(PAPOUCHE_VENDOR, PAPOUCHE_THEM_PROD) },

What about:
s/PAPOUCHE_VENDOR/PAPOUCHE_VID/g
s/PAPOUCHE_THEM_PROD/PAPOUCHE_TMU_PID/g

>         { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
>         { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
>         { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
> diff -uNrbBd old/ftdi_sio.h new/ftdi_sio.h
> --- old/ftdi_sio.h      2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.h      2006-03-24 20:37:35.000000000 +0100
> @@ -20,8 +20,13 @@
>   * Philipp Gühring - pg@xxxxxxxxxxxxx - added the Device ID of the USB relais
You are not using UTF-8 capable MUA or editor or both, so the umlaut is
broken here.

>   * from Rudolf Gugler
>   *
> + * Folkert van Heusden - folkert@xxxxxxxxxxxxxx - added the device id of the
> + * temperature sensor from www.papouch.com

Credits are better with the PID/VID lines, not here. Just look at what
other (most) people have done.

add at least the name [TMU] here

>   */
> 
> +#define PAPOUCHE_VENDOR 0x5050
> +#define PAPOUCHE_THEM_PROD 0x0400

+#define PAPOUCHE_VID 0x5050
+#define PAPOUCHE_TMU_PID 0x0400

> +
>  #define FTDI_VID       0x0403  /* Vendor Id */
>  #define FTDI_SIO_PID   0x8372  /* Product Id SIO application of 8U100AX  */
>  #define FTDI_8U232AM_PID 0x6001 /* Similar device to SIO above */

IMHO, `diff -ruN` or `diff -pruN` should be better when posting patches :-)

Kalin.

-- 
|[ ~~~~~~~~~~~~~~~~~~~~~~ ]|
+-> http://ThinRope.net/ <-+
|[ ______________________ ]|


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/