Re: [RFC PATCH 35/35] Add Xen virtual block device driver.

[Gerd Hoffmann]

  Hi,

>> +static struct xlbd_type_info xlbd_ide_type = {
>> +static struct xlbd_type_info xlbd_scsi_type = {
>> +static struct xlbd_type_info xlbd_vbd_type = {

> This is another thing that has always put me off.  The virtual block
> device driver has the ability to masquerade as other types of block
> devices.  It actually claims to be an IDE or SCSI device allocating the
> appropriate major/minor numbers.

It's useful sometimes.  Debian/sarge for example doesn't work with xvd
block devices.  At least not out-of-the-box, it needs some manual
tweaks.  Probably it also is handy when moving real machines into an
virtual environment.  I don't think it should be dropped.

Most modern udev-based distros work just fine with xvd though.

> This seems to be pretty evil and creating interesting failure conditions
> for users who load IDE or SCSI modules.  I've seen it trip up a number
> of people in the past.  I think we should only ever use the major number
> that was actually allocated to us.

Print a big fat warning?  And also change the example config files in
the xen source tree to use xvda not hda to advertize them more than we
do right now.  I think lots of users don't even know about the xvd
devices ...

cheers,

  Gerd

-- 
Gerd 'just married' Hoffmann <kraxel@xxxxxxx>
I'm the hacker formerly known as Gerd Knorr.
http://www.suse.de/~kraxel/just-married.jpeg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/