Re: [2.6 patch] always enable CONFIG_PDC202XX_FORCE

[Bartlomiej Zolnierkiewicz]

On 3/27/06, Sergei Shtylylov <sshtylyov@xxxxxxxxxxxxx> wrote:
> Hello.
>
> Adrian Bunk wrote:
>
> > This patch removes the CONFIG_PDC202XX_FORCE=n case.
>
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> > ---
> >
> > This patch was already sent on:
> > - 14 Jan 2006
> >
> >  drivers/ide/Kconfig            |    7 -------
> >  drivers/ide/pci/pdc202xx_new.c |    6 ------
> >  drivers/ide/pci/pdc202xx_old.c |   15 ---------------
> >  3 files changed, 28 deletions(-)
>
> [skipped]
>
> > --- linux-2.6.15-mm4-full/drivers/ide/pci/pdc202xx_old.c.old  2006-01-14 20:44:01.000000000 +0100
> > +++ linux-2.6.15-mm4-full/drivers/ide/pci/pdc202xx_old.c      2006-01-14 20:44:21.000000000 +0100
> > @@ -786,9 +786,6 @@
> >               .init_dma       = init_dma_pdc202xx,
> >               .channels       = 2,
> >               .autodma        = AUTODMA,
> > -#ifndef CONFIG_PDC202XX_FORCE
> > -             .enablebits     = {{0x50,0x02,0x02}, {0x50,0x04,0x04}},
> > -#endif
> >               .bootable       = OFF_BOARD,
> >               .extra          = 16,
> >       },{     /* 1 */
> > @@ -799,9 +796,6 @@
> >               .init_dma       = init_dma_pdc202xx,
> >               .channels       = 2,
> >               .autodma        = AUTODMA,
> > -#ifndef CONFIG_PDC202XX_FORCE
> > -             .enablebits     = {{0x50,0x02,0x02}, {0x50,0x04,0x04}},
> > -#endif
> >               .bootable       = OFF_BOARD,
> >               .extra          = 48,
> >               .flags          = IDEPCI_FLAG_FORCE_PDC,
>
>     A late question: wasn't that IDEPCI_FLAG_FORCE_PDC flag there for the same
> purpose -- to bypass enablebits check? Wasn't it enough?

It was for the same purpose but it wasn't enough,
now this flag can die...

Bartlomiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/