Re: Correction: 2.6.16-git12 killed networking -- 3c900 card

[Steffen Klassert]

On Tue, Mar 28, 2006 at 11:44:54AM -0500, Pete Clements wrote:
> Quoting Steffen Klassert
>   > > 
>   > > FYI:
>   > >   Single 3c900 card, UP i386
>   > >   Lost networking with .16-git12, message
>   > >   ADDRCONF(NETDEV_UP): eth0: link is not ready
>   > 
>   > This could be due to the recent driver update.
>   > I can not reproduce this with a 3c900B-Combo,
>   > so I need some more information to track it down.
> 
> Data attached. Note:
>  1) Using coax 10base2.

Somehow 10base2 does not like a netif_carrier_off.

Please try the pach below. It makes 10base2 work again for me.

Steffen

--- linux-2.6.16-git12/drivers/net/3c59x.c	2006-03-29 11:23:48.000000000 +0200
+++ linux-2.6.16-git12-sk/drivers/net/3c59x.c	2006-03-29 13:40:28.000000000 +0200
@@ -1723,7 +1723,6 @@
 		printk(KERN_DEBUG "vortex_up(): writing 0x%x to InternalConfig\n", config);
 	iowrite32(config, ioaddr + Wn3_Config);
 
-	netif_carrier_off(dev);
 	if (dev->if_port == XCVR_MII || dev->if_port == XCVR_NWAY) {
 		EL3WINDOW(4);
 		vortex_check_media(dev, 1);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/