Re: [PATCH][RFC] splice support
From: Jens Axboe
Date: Thu Mar 30 2006 - 01:15:46 EST
On Wed, Mar 29 2006, Andrew Morton wrote:
> Jeff Garzik <jeff@xxxxxxxxxx> wrote:
> >
> > Linus Torvalds wrote:
> > > The "destination first" convention is insane. It only makes sense for
> > > assignments, and these aren't assignments.
> >
> > I agree.
> >
> > But alas, sendfile(2) is defined as destination first:
> >
> > > ssize_t sendfile(int out_fd, int in_fd, off_t *offset, size_t count)
> >
> > which begs the question, do we want to be different from sendfile(2),
> > and confuse a segment of the programmer populace? :)
> >
>
> strcpy, memcpy...
>
> Obviously copy(from, to) is the sane way to do things, but yeah, I _think_
> a C programmer would expect copy(to, from).
>
> I don't think it matters much at all, really. If they get it backwards
> they'll notice pretty quickly ;)
Yeah, I've always thought that the sendfile() arguments are stupidly
transposed :-)
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/