Re: [PATCH][RFC] splice support

[Nick Piggin]

Linus Torvalds wrote:

> On Wed, 29 Mar 2006, Andrew Morton wrote:
>
> > - splice() take a size_t length.  Should it be taking a 64-bit length?
>
> No. You can't splice more than the kernel buffers anyway (ie currently 
> PIPE_BUFFERS pages, ie ~64kB, although in theory somebody could use large 
> pages for it), so 64-bit would be total overkill.

But in that case you'll just end up blocking on the pipe won't you? I
think Andrew's talking about the syscall itself, which should be 64-bit
surely.

Hmm, with no "offset" parameter, you cannot splice-sendfile >4GB files...
Or am I going crazy? I see, it uses f_pos. Should it use offsets instead?
I guess you covered this in your earlier sys_splice discussions. I'll do
some research.

--

Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/