Re: [Patch 3/8] cpu delays

[Dave Hansen]

On Wed, 2006-03-29 at 19:42 -0500, Shailabh Nagar wrote:
> 
> -#ifdef CONFIG_SCHEDSTATS
> -       memset(&p->sched_info, 0, sizeof(p->sched_info));
> +#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
> +       if (unlikely(sched_info_on()))
> +               memset(&p->sched_info, 0, sizeof(p->sched_info));
>  #endif 

If you unconditionally define sched_info_on(), you can get get rid of
this #ifdef.

+#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT)
+
+static inline int sched_info_on(void)
+{
+ #ifdef CONFIG_SCHEDSTATS
+       return 1;
+#elif defined(CONFIG_TASK_DELAY_ACCT)
+       return delayacct_on;
+#else
+	return 0;
+#endif
+}

Might as well hide the junk in a header.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/