Re: [PATCH][UPDATE] rtc: Added support for ds1672 control

[Kumar Gala]

On Mar 28, 2006, at 5:57 PM, Alessandro Zummo wrote:

> On Tue, 28 Mar 2006 17:52:00 -0600
> Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > >  shouldn't this be
> > >  if (err < 0)
> > > 	return err;
> >
> > It could be, but doesn't need to.  ds1672_get_control either returns
> > 0 (success) or non-zero (-EIO) for failure.
> >
> > > > +	/* read control register */
> > > > +	err = ds1672_get_control(client, &control);
> > > > +	if (err) {
> > > > +		dev_err(&client->dev, "%s: read error\n", __FUNCTION__);
> > > > +		goto exit_detach;
> > > > +	}
> > >
> > >  ditto.
> >
> > ditto.
>
>  ok. will apply, thanks.

Do you have a queue of patches for 2.6.17 or should I send this to  
Andrew to get into 2.6.17?

- kumar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/