[PATCH] isd200: limit to BLK_DEV_IDE

From: Randy.Dunlap
Date: Thu Mar 30 2006 - 17:40:33 EST


On Thu, 30 Mar 2006, Beber wrote:

> On 3/28/06, Greg KH <gregkh@xxxxxxx> wrote:
> > We (the -stable team) are announcing the release of the 2.6.16.1 kernel.
>
> I still get this error :
>
> # make
...
> drivers/built-in.o: In function `isd200_Initialization':
> : undefined reference to `ide_fix_driveid'
> make: *** [.tmp_vmlinux1] Error 1

Was this reported earlier?

Please test the patch below.
It works for me with your config and various others.



From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

Limit USB_STORAGE_ISD200 to whatever BLK_DEV_IDE and USB_STORAGE
are set to (y, m) since isd200 calls ide_fix_driveid() in the
BLK_DEV_IDE code.

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
---
drivers/usb/storage/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2616-z.orig/drivers/usb/storage/Kconfig
+++ linux-2616-z/drivers/usb/storage/Kconfig
@@ -48,7 +48,7 @@ config USB_STORAGE_FREECOM

config USB_STORAGE_ISD200
bool "ISD-200 USB/ATA Bridge support"
- depends on USB_STORAGE && BLK_DEV_IDE
+ depends on USB_STORAGE && (BLK_DEV_IDE=y || BLK_DEV_IDE=m && USB_STORAGE=m)
---help---
Say Y here if you want to use USB Mass Store devices based
on the In-Systems Design ISD-200 USB/ATA bridge.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/