Re: Hook collie frontlight into sysfs

[Richard Purdie]

On Fri, 2006-03-31 at 10:23 +0200, Pavel Machek wrote:
> Hi!
> 
> > During our test with Richard, we've been thinking can you implement the
> > full range of brightness intensity values? For example for the others
> > Zaurus, I think the range is between 0 and 63. So the userspace can
> 
> Well, I'm not sure if other values are "legal". They could damage
> frontlight long-term or just eat too much power...

For what its worth, these back/frontlight controllers are normally PWM
driven so the LED is always at full brightness and just the percentage
of time its turned on varies. These numbers in the driver control the
duty cycle of the PWM.

The original code for corgi/spitz only had a limited number of values
and I exposed the whole range into userspace. I doubt you can damage the
hardware with the different values. There are probably optimal points
for power consumption which is perhaps why Sharp limited the values
exposed. My view is that its up to userspace to limit the values for
optimal power consumption :).

> > adjust a wider range of levels for the backlight. Another thing, I
> > didn't see anything different visually between the value 3 and 4.
> 
> You are right, the code to go brightness 4 is attached. It probably
> needs to be converted to writel/readl...

This makes sense as on corgi/spitz there is also this magic bit to set
for the second level of brightness settings...

I'll have a look at these patches and perhaps combine/convert them to
the replacement backlight interface, then we can submit them to Antonino
Daplas/Andrew so all the backlight patches are in one place (currently
-mm).

Given what I've said above, would you be happy to expose the full range
of values to userspace?

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/