Re: [patch] avoid unaligned access when accessing poll stack

From: Andi Kleen
Date: Fri Mar 31 2006 - 10:57:34 EST


On Friday 31 March 2006 17:38, Jes Sorensen wrote:
> Hi,
>
> Patch 70674f95c0a2ea694d5c39f4e514f538a09be36f
> [PATCH] Optimize select/poll by putting small data sets on the stack
> resulted in the poll stack being 4-byte aligned on 64-bit
> architectures, causing misaligned accesses to elements in the array.
>
> This patch fixes it by declaring the stack in terms of 'long' instead
> of 'char'.

You should do that for poll too then.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/