Re: + git-klibc-mktemp-fix.patch added to -mm tree

[H. Peter Anvin]

Sam Ravnborg wrote:
> On Sat, Apr 08, 2006 at 12:05:54AM -0700, akpm@xxxxxxxx wrote:
> > diff -puN usr/dash/mkbuiltins~git-klibc-mktemp-fix usr/dash/mkbuiltins
> > --- 25/usr/dash/mkbuiltins~git-klibc-mktemp-fix	Sat Apr  8 14:51:11 2006
> > +++ 25-akpm/usr/dash/mkbuiltins	Sat Apr  8 14:51:11 2006
> > @@ -37,7 +37,7 @@
> >  
> >  tempfile=tempfile
> >  if ! type tempfile > /dev/null 2>&1; then
> > -	tempfile=mktemp
> > +	tempfile="mktemp /tmp/tmp.XXXXXX"
>
> Shouldn't that be:
> > +	tempfile="$(mktemp /tmp/tmp.XXXXXX)"

No, it's invoked later on as:

temp=$($tempfile)
temp2=$($tempfile)

Either which way; I have a better fix for the bison issue (this all has 
to do with the fact that make's handling of tools that output more than 
one file at a time is at the very best insane); however, I'm getting 
rather unhappy with some of the code in dash.

In particular, mksyntax.c seems to assume it runs on the same machine 
that the resulting code is going to execute on, for example, it tries to 
detect whether or not "char" is signed, but that doesn't work when 
cross-compiling.

dash isn't actually necessary in the in-kernel build, although it's a 
very nice bonus for customizing initramfs to have a shell to glue things 
together with.

Herbert: can the code be restructured with appropriate casts so that 
signed/unsigned is factored out of mksyntax?  As it currently stands, 
it's not cross-compile-safe, which is unacceptable.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/