Re: + git-klibc-mktemp-fix.patch added to -mm tree

[Bodo Eggert]

Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Sat, Apr 08, 2006 at 12:05:54AM -0700, akpm@xxxxxxxx wrote:

>> diff -puN usr/dash/mkbuiltins~git-klibc-mktemp-fix usr/dash/mkbuiltins
>> --- 25/usr/dash/mkbuiltins~git-klibc-mktemp-fix      Sat Apr  8 14:51:11 2006
>> +++ 25-akpm/usr/dash/mkbuiltins      Sat Apr  8 14:51:11 2006

>> -    tempfile=mktemp
>> +    tempfile="mktemp /tmp/tmp.XXXXXX"
> 
> Shouldn't that be:
>> +    tempfile="$(mktemp /tmp/tmp.XXXXXX)"

No. You should use tempfile="$(mktemp ${TMPDIR:-/tmp}/tmp.XXXXXX)"
(or mktemp -t, if it's portable enough)

Besides that, tmp.XXXXXX should be replayed using a better name.

</nitpick>
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/