[PATCH ACPI] memory leak in acpi_evaluate_integer()

From: Vasily Averin
Date: Sun Apr 09 2006 - 11:05:32 EST


acpi_evaluate_integer() does not release allocated memory on the error path.

Signed-off-by: Vasily Averin <vvs@xxxxx>

Thank you,
Vasily Averin

SWsoft Virtuozzo/OpenVZ Linux kernel team
--- a/drivers/acpi/utils.c 2006-04-09 14:31:39.000000000 +0400
+++ b/drivers/acpi/utils.c 2006-04-09 14:35:02.000000000 +0400
@@ -273,11 +273,13 @@ acpi_evaluate_integer(acpi_handle handle
status = acpi_evaluate_object(handle, pathname, arguments, &buffer);
if (ACPI_FAILURE(status)) {
acpi_util_eval_error(handle, pathname, status);
+ kfree(element);
return_ACPI_STATUS(status);
}

if (element->type != ACPI_TYPE_INTEGER) {
acpi_util_eval_error(handle, pathname, AE_BAD_DATA);
+ kfree(element);
return_ACPI_STATUS(AE_BAD_DATA);
}