Re: [PATCH 3/4] coredump: kill ptrace related stuff

[Roland McGrath]

> With this patch zap_process() sets SIGNAL_GROUP_EXIT while sending
> SIGKILL to the thread group. 

do_coredump has already done this.  So you are addressing the case of other
thread groups sharing the mm, right?

> This means that a TASK_TRACED task
> 
> 	1. Will be awakened by signal_wake_up(1)

That should always happen regardless of signal->flags, so yes.

> 	2. Can't sleep again via ptrace_notify()

What makes this be so?  What if it's entering a notification event now?
What about exit tracing?

> 	3. Can't go to do_signal_stop() after return
> 	   from ptrace_stop() in get_signal_to_deliver()

This is only true because of the check in get_signal_to_deliver,
which I've said I think should be taken out for other reasons.

I guess I'm missing something here.


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/