[Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c

From: Eric Sesterhenn
Date: Mon Apr 10 2006 - 06:16:00 EST


hi,

since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST],
it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>

--- linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c.orig 2006-04-10 12:10:22.000000000 +0200
+++ linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c 2006-04-10 12:10:41.000000000 +0200
@@ -506,7 +506,7 @@ static int __devinit snd_vortex_new_pcm(
int i;
int err, nr_capt;

- if ((chip == 0) || (idx < 0) || (idx > VORTEX_PCM_LAST))
+ if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
return -ENODEV;

/* idx indicates which kind of PCM device. ADB, SPDIF, I2S and A3D share the


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/