Re: [git patch] libata scsi eh fixed to use transport class

[Jeff Garzik]

Jeff Garzik wrote:
> diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
> index fa901fd..0ebf136 100644
> --- a/drivers/scsi/sata_mv.c
> +++ b/drivers/scsi/sata_mv.c
> @@ -378,8 +378,6 @@ static struct scsi_host_template mv_sht 
>  	.name			= DRV_NAME,
>  	.ioctl			= ata_scsi_ioctl,
>  	.queuecommand		= ata_scsi_queuecmd,
> -	.eh_strategy_handler	= ata_scsi_error,
> -	.can_queue		= MV_USE_Q_DEPTH,
>  	.this_id		= ATA_SHT_THIS_ID,
>  	.sg_tablesize		= MV_MAX_SG_CT / 2,
>  	.cmd_per_lun		= ATA_SHT_CMD_PER_LUN,

And the obvious patch (attached) was just checked in, to fix the above 
deletion that was in Christoph's original patch, subsequently merged.

	Jeff


commit 1b72373491a061be6d456d219a4e2d054ac2aaad
Author: Jeff Garzik <jeff@xxxxxxxxxx>
Date:   Mon Apr 10 14:56:39 2006 -0400

    [libata] sata_mv: fix can_queue line accidentally removed in scsi-eh patch

1b72373491a061be6d456d219a4e2d054ac2aaad
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
index 0ebf136..b64b077 100644
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -378,6 +378,7 @@ static struct scsi_host_template mv_sht 
 	.name			= DRV_NAME,
 	.ioctl			= ata_scsi_ioctl,
 	.queuecommand		= ata_scsi_queuecmd,
+	.can_queue		= MV_USE_Q_DEPTH,
 	.this_id		= ATA_SHT_THIS_ID,
 	.sg_tablesize		= MV_MAX_SG_CT / 2,
 	.cmd_per_lun		= ATA_SHT_CMD_PER_LUN,