Re: [PATCH 3/3] deinline a few large functions in vlan code - v3

From: David S. Miller
Date: Tue Apr 11 2006 - 03:58:59 EST


From: Denis Vlasenko <vda@xxxxxxxxxxxxx>
Date: Tue, 11 Apr 2006 10:47:36 +0300

> On Tuesday 11 April 2006 10:44, Denis Vlasenko wrote:
> On Tuesday 11 April 2006 10:43, Denis Vlasenko wrote:
> > These patches exclude VLAN code from netdevice drivers
> > and from bonding module, and even remove vlan-related
> > members of struct netdevice if VLAN is not configured.
> >
> > Compile tested on allyesconfig kernel with CONFIG_8021Q=y,m,n.
>
> This one add #ifdefs around vlan_rx_* members of struct netdevice,
> and moves large inlines out-of-line.

This is not very nice, there is no way I'm applying these patches.

I think the current situation is far better than the large pile of
ifdefs these patches are adding to the tree.

Let's just leave things the way they are ok?
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html