Re: [PATCH 1/2] aic7xxx: deinline large functions, save 80k of text

From: Hannes Reinecke
Date: Wed Apr 12 2006 - 09:56:05 EST


Denis Vlasenko wrote:
> This patch
>
> moves big inlines into aic79xx_core.c and aic7xxx_core.c
> makes ahd_delay just a wrapper around udelay
> marks a few functions static
> fixes spelling fix in error message
While you're at it; can't you move the different ah{c,d}_{in,out}.* into
one place? Have them scattered throughout the file doesn't really make
sense.

Otherwise ACK.

Cheers,

Hannes
--
Dr. Hannes Reinecke hare@xxxxxxx
SuSE Linux Products GmbH S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/