Re: [RFC: 2.6 patch] kernel/sys.c: possible cleanups

[Andrew Morton]

Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
> This patch contains the following possible cleanups:

Please avoid mixing together cleanups

>  - proper prototypes for the following functions:
>    - ctrl_alt_del()  (in include/linux/reboot.h)
>    - getrusage()     (in include/linux/resource.h)
>  - make the following needlessly global functions static:
>    - kernel_restart_prepare()
>    - kernel_kexec()

which I will apply, together with API changes

>  - remove the following unused EXPORT_SYMBOL:
>    - in_egroup_p
>  - remove the following unused EXPORT_SYMBOL_GPL's:
>    - kernel_restart
>    - kernel_halt

which I will not.

We have a process for the latter.  And even if we ignore that process, the
patch ends up sitting in -mm for ages because of the API change, along with
the cleanups, which could be merged up promptly.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/